What is Best Practice for Handling Script Errors in Execute Script Action?

[JMichaelTX]

@DanThomas

If you're going to return results, as opposed to setting KM variables, then this method is OK as long as an empty result is not valid. But if there's ever a time when an empty result is valid, then you can't use this method, because there's no way to guarantee that the script actually ran.

All good points.

My example is just that, an example, not a finished product.

Actually, I think that if the script did not return "[ERROR]", and KM did not throw any errors, then it is a safe bet that it did actually run. Do you see some other issue?

It is easy enough to change the IF/THEN to a SWITCH/CASE, and handle each return type separately. That would probably be best in a finished product.

@DanThomas

Regardless, I don't see a problem with returning things like "user canceled" in the result - that's cool. But, in your example, you combine them all into one general-purpose error message, so I don't see the point.

Well, there are two points:

1. The error msg the user sees is different
2. As I just said above, use SWITCH/CASE if you want to handle the different returns.

@DanThomas

By the way, you should verify that whatever method you choose (in JXA scripts) works correctly in that Yosemite environment that causes the strange warnings.

This is easily handled by:

1. Uncheck "Include Errors" in the Execute Script action
2. Use try/catch in the script

@DanThomas

And just to verify that I'm thinking correctly, we should ALWAYS (in JXA) wrap everything in a try/catch,

Yes, just like I did in my AppleScript example, and in the JXA example before that.

All said, I think we are in general agreement.

However, my main question was checking for "[ERROR]" vs "[OK]".
Do you have any thoughts on that?